fix 593, reduce cloning by taking ownership in logical planner's from fn
#610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimexist
changed the title
from fn
alamb
approved these changes
Jun 23, 2021
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Yes, I really like this change (there is far too much cloning in the creation of plans (and Exprs generally). It is an API change so I think maybe we should leave it open for a few days to see if anyone else has opinions
jorgecarleitao
approved these changes
Jun 23, 2021
Member
jorgecarleitao
left a comment
jorgecarleitao
left a comment
There was a problem hiding this comment.
Solid improvement to me 👍 Tjhanks @jimexist !
houqp
approved these changes
Jun 24, 2021
Member
|
If we really want to make this backwards compatible, we could use |
Dandandan
approved these changes
Jun 25, 2021
Member
Author
thanks for the suggestion. unless it's a goal, i'd like to keep this simple for the moment. |
Contributor
|
Thanks again @jimexist |
unkloud
pushed a commit
to unkloud/datafusion
that referenced
this pull request
Mar 23, 2025
H0TB0X420
pushed a commit
to H0TB0X420/datafusion
that referenced
this pull request
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #593
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?