doc: fix site sidebar logo position #5990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Web design isn't my forte but this seems to solve the issue |
alamb
approved these changes
Apr 13, 2023
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Web design isn't my forte
😆 me neither -- I am well out of my league here.
I tested locally and when i had the screen fairly small with this change there was no padding around the logio
https://arrow.apache.org/datafusion/
This PR
That being said, when there was enough width things seemed to be good with this PR
So I think while not perfect this is a step in the right direction. Thank you @Jefffrey
jackwener
approved these changes
Apr 14, 2023
Contributor
Author
|
Padding added to left & right sides now
cc @alamb |
Contributor
|
I took it for a spin locally, and it worked great. Thank you @Jefffrey ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5935
Rationale for this change
Fix site sidebar logo position to respect the scrolling sidebar and always remain below it (and not overlap)
What changes are included in this PR?
Example:
Are these changes tested?
Are there any user-facing changes?