Skip to content

Conversation

@yjshen
Copy link
Member

@yjshen yjshen commented Apr 13, 2023

Which issue does this PR close?

Closes #.
Fixes failing CI https://github.com/apache/arrow-datafusion/actions/runs/4685079004/jobs/8301949150

Probably broken by #5962

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Then, in `main.rs.` update the memory allocator with the below after your imports:

```rust
```rust,ignore
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it need add blank between them?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it locally, and it doesn't need a blank line. I'll enable doctest CI as well in the next commit

@alamb
Copy link
Contributor

alamb commented Apr 13, 2023

Thanks @yjshen and @jackwener -- I think I probably broke this with #5962

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @yjshen

@yjshen yjshen merged commit a55d805 into apache:main Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants