feat: hyperbolic functions #5884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
alamb
reviewed
Apr 7, 2023
|
|
||
| ### `cbrt` | ||
|
|
||
| Returns the cube root of a number. |
Contributor
There was a problem hiding this comment.
Thank you for cleaning this up in "drive by" fashion 👍
| test_expression!("asin(NULL)", "NULL"); | ||
| test_expression!("acos(NULL)", "NULL"); | ||
| test_expression!("atan(NULL)", "NULL"); | ||
| test_expression!("sinh(NULL)", "NULL"); |
Contributor
There was a problem hiding this comment.
I am sorry if I missed it in my review, but are these new functions tested with non null inputs?
Specifically it would be great to see a sql level test that invoked them with values
Contributor
Author
There was a problem hiding this comment.
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #5838
Rationale for this change
What changes are included in this PR?
Hyperbolic functions and inverse hyperbolic functions:
Are these changes tested?
Partially
Are there any user-facing changes?
Yes