Consolidate OwnedTableReference with TableReference#5508
Closed
alamb wants to merge 3 commits intoapache:mainfrom
Closed
Consolidate OwnedTableReference with TableReference#5508alamb wants to merge 3 commits intoapache:mainfrom
OwnedTableReference with TableReference#5508alamb wants to merge 3 commits intoapache:mainfrom
Conversation
github-actions
bot
added
core
alamb
changed the title
alamb
changed the title
OwnedTableReference with TableReference
Contributor
|
I see what you mean now, it didn't occur to me to use Maybe change |
Contributor
Author
That may help people understand how to use it better. I'll give it a try and see what it looks like |
Contributor
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #5343. I am trying to specifically demonstrate what I was talking about on https://github.com/apache/arrow-datafusion/pull/5343/files#r1123708924
Rationale for this change
TableReferencevsOwnedTableReferenceand having to convert back and forth between them is cumbersome to work with. This PR proposes removing theOwnedTableReferenceasTableReferencecan actually hold an owned string (viaCow<'static>What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?