Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipeline-friendly Bounded Memory Window Executor #4777

Merged
merged 64 commits into from
Jan 4, 2023
Merged

Pipeline-friendly Bounded Memory Window Executor #4777

merged 64 commits into from
Jan 4, 2023

Commits on Dec 13, 2022

  1. Sort Removal rule initial commit

    @mustafasrepo
    mustafasrepo committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    56db313 View commit details
    Browse the repository at this point in the history

  2. move ordering satisfy to the util

    @mustafasrepo
    mustafasrepo committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    343fafb View commit details
    Browse the repository at this point in the history

  3. update test and change repartition maintain_input_order impl

    @mustafasrepo
    mustafasrepo committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    dfb6683 View commit details
    Browse the repository at this point in the history

  4. simplifications

    @mustafasrepo
    mustafasrepo committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    0a42315 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2022

  1. partition by refactor (#28) 

    * partition by refactor

* minor changes

* Unnecessary tuple to Range conversion is removed

* move transpose under common
    @mustafasrepo
    mustafasrepo authored Dec 15, 2022
    Configuration menu
    Copy the full SHA
    c2a1593 View commit details
    Browse the repository at this point in the history

  2. Add naive sort removal rule

    @mustafasrepo
    mustafasrepo committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    bf7bd11 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2022

  1. Add todo for finer Sort removal handling

    @mustafasrepo
    mustafasrepo committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    4cb7258 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'apache:master' into feature/sort_removal_rule

    @mustafasrepo
    mustafasrepo authored Dec 16, 2022
    Configuration menu
    Copy the full SHA
    dbc30ab View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2022

  1. Refactors to improve readability and reduce nesting

    @ozankabak
    ozankabak committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    aa4f739 View commit details
    Browse the repository at this point in the history

  2. reverse expr returns Option (no need for support check)

    @mustafasrepo
    mustafasrepo committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    6309b01 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2022

  1. Merge branch 'master' into feature/sort_removal_rule

    @mustafasrepo
    mustafasrepo authored Dec 20, 2022
    Configuration menu
    Copy the full SHA
    d0d06de View commit details
    Browse the repository at this point in the history

  2. fix tests

    @mustafasrepo
    mustafasrepo committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    91629b8 View commit details
    Browse the repository at this point in the history

  3. partition by and order by no longer ends up at the same window group

    @mustafasrepo
    mustafasrepo committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    ae451a4 View commit details
    Browse the repository at this point in the history

  4. Bounded window exec

    @mustafasrepo
    mustafasrepo committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    94c784b View commit details
    Browse the repository at this point in the history

  5. Merge branch 'feature/sort_removal_rule' into feature/bounded_window_… 

    …exec
    @mustafasrepo
    mustafasrepo authored Dec 20, 2022
    Configuration menu
    Copy the full SHA
    7c4bcb9 View commit details
    Browse the repository at this point in the history

  6. solve merge problems

    @mustafasrepo
    mustafasrepo committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    0068566 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2022

  1. Refactor to simplify code

    @ozankabak
    ozankabak committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    0e73945 View commit details
    Browse the repository at this point in the history

  2. Better comments, change method names

    @ozankabak
    ozankabak committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    4f145dd View commit details
    Browse the repository at this point in the history

  3. Merge branch 'feature/sort_removal_rule' into feature/bounded_window_… 

    …exec
    @mustafasrepo
    mustafasrepo authored Dec 21, 2022
    Configuration menu
    Copy the full SHA
    c63057f View commit details
    Browse the repository at this point in the history

  4. resolve merge conflicts

    @mustafasrepo
    mustafasrepo committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    838972c View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2022

  1. Merge branch 'apache:master' into feature/sort_removal_rule

    @mustafasrepo
    mustafasrepo authored Dec 22, 2022
    Configuration menu
    Copy the full SHA
    6d9a876 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'apache:master' into feature/bounded_window_exec

    @mustafasrepo
    mustafasrepo authored Dec 22, 2022
    Configuration menu
    Copy the full SHA
    f2c7286 View commit details
    Browse the repository at this point in the history

  3. Resolve errors introduced by syncing

    @mustafasrepo
    mustafasrepo committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    6b07621 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'feature/sort_removal_rule' into feature/bounded_window_… 

    …exec
    @mustafasrepo
    mustafasrepo authored Dec 22, 2022
    Configuration menu
    Copy the full SHA
    d62bbdc View commit details
    Browse the repository at this point in the history

  5. remove set_state, make ntile debuggable

    @mustafasrepo
    mustafasrepo committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    a2d2229 View commit details
    Browse the repository at this point in the history

  6. remove locked flag

    @mustafasrepo
    mustafasrepo committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    63d77a6 View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2022

  1. Merge branch 'feature/sort_removal_rule' of https://github.com/synnad… 

    …a-ai/arrow-datafusion into feature/sort_removal_rule

# Conflicts:
#	datafusion/physical-expr/src/aggregate/count.rs
#	datafusion/physical-expr/src/aggregate/mod.rs
#	datafusion/physical-expr/src/aggregate/sum.rs
#	datafusion/physical-expr/src/window/aggregate.rs
    @mustafasrepo
    mustafasrepo committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    28075e6 View commit details
    Browse the repository at this point in the history

  2. address reviews

    @mustafasrepo
    mustafasrepo committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    ba388cb View commit details
    Browse the repository at this point in the history

  3. address reviews

    @mustafasrepo
    mustafasrepo committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    572a1a4 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'feature/sort_removal_rule' into feature/bounded_window_… 

    …exec
    @mustafasrepo
    mustafasrepo authored Dec 23, 2022
    Configuration menu
    Copy the full SHA
    fa30d91 View commit details
    Browse the repository at this point in the history

  5. Resolve merge conflict

    @mustafasrepo
    mustafasrepo committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    af60aa9 View commit details
    Browse the repository at this point in the history

  6. address reviews

    @mustafasrepo
    mustafasrepo committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    ca711e4 View commit details
    Browse the repository at this point in the history

  7. address reviews

    @mustafasrepo
    mustafasrepo committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    eb97a5c View commit details
    Browse the repository at this point in the history

Commits on Dec 26, 2022

  1. address reviews

    @mustafasrepo
    mustafasrepo committed Dec 26, 2022
    Configuration menu
    Copy the full SHA
    36394c0 View commit details
    Browse the repository at this point in the history

  2. Add new tests

    @mustafasrepo
    mustafasrepo committed Dec 26, 2022
    Configuration menu
    Copy the full SHA
    8b3d37f View commit details
    Browse the repository at this point in the history

  3. Update tests

    @mustafasrepo
    mustafasrepo committed Dec 26, 2022
    Configuration menu
    Copy the full SHA
    25af93c View commit details
    Browse the repository at this point in the history

  4. add support for bounded min max

    @mustafasrepo
    mustafasrepo committed Dec 26, 2022
    Configuration menu
    Copy the full SHA
    2b2b376 View commit details
    Browse the repository at this point in the history

  5. address reviews

    @mustafasrepo
    mustafasrepo committed Dec 26, 2022
    Configuration menu
    Copy the full SHA
    670fe32 View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2022

  1. rename sort rule

    @mustafasrepo
    mustafasrepo committed Dec 27, 2022
    Configuration menu
    Copy the full SHA
    3ea9eed View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feature/bounded_window_exec

    @mustafasrepo
    mustafasrepo authored Dec 27, 2022
    Configuration menu
    Copy the full SHA
    3892394 View commit details
    Browse the repository at this point in the history

  3. Resolve merge conflicts

    @mustafasrepo
    mustafasrepo committed Dec 27, 2022
    Configuration menu
    Copy the full SHA
    ca666e9 View commit details
    Browse the repository at this point in the history

  4. refactors

    @mustafasrepo
    mustafasrepo committed Dec 27, 2022
    Configuration menu
    Copy the full SHA
    73d99c6 View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2022

  1. Update fuzzy tests + minor changes

    @mustafasrepo
    mustafasrepo committed Dec 28, 2022
    Configuration menu
    Copy the full SHA
    09c1942 View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2022

  1. Simplify code and improve comments

    @ozankabak
    ozankabak committed Dec 29, 2022
    Configuration menu
    Copy the full SHA
    39564d4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feature/bounded_window_exec

    @ozankabak
    ozankabak authored Dec 29, 2022
    Configuration menu
    Copy the full SHA
    9f73ba7 View commit details
    Browse the repository at this point in the history

  3. Fix imports, make create_schema more functional

    @ozankabak
    ozankabak committed Dec 29, 2022
    Configuration menu
    Copy the full SHA
    8ac3847 View commit details
    Browse the repository at this point in the history

  4. address reviews

    @mustafasrepo
    mustafasrepo committed Dec 29, 2022
    Configuration menu
    Copy the full SHA
    3349edf View commit details
    Browse the repository at this point in the history

  5. undo yml change

    @mustafasrepo
    mustafasrepo committed Dec 29, 2022
    Configuration menu
    Copy the full SHA
    701c43e View commit details
    Browse the repository at this point in the history

  6. minor change to pass from CI

    @mustafasrepo
    mustafasrepo committed Dec 29, 2022
    Configuration menu
    Copy the full SHA
    3b523b4 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into feature/bounded_window_exec

    @mustafasrepo
    mustafasrepo authored Dec 29, 2022
    Configuration menu
    Copy the full SHA
    28773ab View commit details
    Browse the repository at this point in the history

  8. resolve merge conflicts

    @mustafasrepo
    mustafasrepo committed Dec 29, 2022
    Configuration menu
    Copy the full SHA
    15d416a View commit details
    Browse the repository at this point in the history

  9. rename some members

    @mustafasrepo
    mustafasrepo committed Dec 29, 2022
    Configuration menu
    Copy the full SHA
    9ceb137 View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2022

  1. Move rule to physical planning

    @mustafasrepo
    mustafasrepo committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    8b9aa6f View commit details
    Browse the repository at this point in the history

  2. Minor stylistic/comment changes

    @ozankabak
    ozankabak committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    e13d6e0 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into feature/bounded_window_exec

    @ozankabak
    ozankabak authored Dec 30, 2022
    Configuration menu
    Copy the full SHA
    93b8d80 View commit details
    Browse the repository at this point in the history

Commits on Dec 31, 2022

  1. Simplify batch-merging utility functions

    @ozankabak
    ozankabak committed Dec 31, 2022
    Configuration menu
    Copy the full SHA
    d97a1ad View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2023

  1. Remove unnecessary clones, simplify code

    @ozankabak
    ozankabak committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    29007ea View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2023

  1. Merge branch 'master' into feature/bounded_window_exec

    @mustafasrepo
    mustafasrepo authored Jan 3, 2023
    Configuration menu
    Copy the full SHA
    a5019c3 View commit details
    Browse the repository at this point in the history

  2. update cargo lock file

    @mustafasrepo
    mustafasrepo committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    ac2f248 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2023

  1. address reviews

    @mustafasrepo
    mustafasrepo committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    0ca3889 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feature/bounded_window_exec

    @mustafasrepo
    mustafasrepo authored Jan 4, 2023
    Configuration menu
    Copy the full SHA
    516e512 View commit details
    Browse the repository at this point in the history

  3. update comments

    @mustafasrepo
    mustafasrepo committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    1e764dd View commit details
    Browse the repository at this point in the history

  4. resolve linter error

    @mustafasrepo
    mustafasrepo committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    28d68bb View commit details
    Browse the repository at this point in the history

  5. Tidy up comments after final review

    @ozankabak
    ozankabak committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    c4b61c5 View commit details
    Browse the repository at this point in the history