Provide a constructor for the ConfigOptions with a string hash map #4758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
yahoNanJing
force-pushed
the
issue-4752
branch
from
ae81823 to
49c5784
Compare
added 2 commits
December 28, 2022 17:14
… use datafusion.execution.batch_size instead
yahoNanJing
force-pushed
the
issue-4752
branch
from
49c5784 to
aa24281
Compare
|
This is so exciting! |
|
FYI the config options rework in #4771 supports this out of the box, PTAL 😄 |
|
I think this PR may no longer be relevant and has accumulated many conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4752, #3500.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?