Skip to content

Conversation

@retikulum
Copy link
Contributor

Which issue does this PR close?

Closes #3152 .

Rationale for this change

I think this is the last PR in this series. There are still usages of array.as_any().downcast_ref but they are used in macros as generic downcasting. You can find them in the following screenshot. They seem OK to me. What is your opinion?

image

What changes are included in this PR?

Refactor parts where old casting schema is used.

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the physical-expr Changes to the physical-expr crates label Dec 12, 2022
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They seem OK to me. What is your opinion?

I agree -- thank you for your perseverance and diligence @retikulum

@alamb alamb merged commit b822b0e into apache:master Dec 12, 2022
@retikulum
Copy link
Contributor Author

They seem OK to me. What is your opinion?

I agree -- thank you for your perseverance and diligence @retikulum

Thanks for all your support. Those PRs are funnier and more instructive than I expected :)

@retikulum retikulum deleted the 3152_improve_error_handling branch December 13, 2022 06:34
@ursabot
Copy link

ursabot commented Dec 13, 2022

Benchmark runs are scheduled for baseline = 0f0d335 and contender = b822b0e. b822b0e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

physical-expr Changes to the physical-expr crates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve codebase readability and error messages by and consistently handle downcasting

3 participants