Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Nov 23, 2022

Which issue does this PR close?

re #4272

Rationale for this change

I noticed in #4272 from @jackwener that some comments were lost. I found this kind of rewrite somewhat mind bending, so figured I would put them back

What changes are included in this PR?

Add docstrings to EliminateOuterJoins

Are these changes tested?

No

Are there any user-facing changes?

Not really

@github-actions github-actions bot added the optimizer Optimizer rules label Nov 23, 2022
@alamb alamb marked this pull request as ready for review November 23, 2022 17:39
@alamb alamb changed the title Minor: Add docstrings to EliminateOuterJoins Minor: Add docstrings to EliminateOuterJoins optimizer pass Nov 23, 2022
@alamb alamb merged commit e1204a5 into apache:master Nov 24, 2022
@alamb alamb deleted the alamb/restore_docs branch November 24, 2022 11:38
@ursabot
Copy link

ursabot commented Nov 24, 2022

Benchmark runs are scheduled for baseline = 561be4f and contender = e1204a5. e1204a5 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

optimizer Optimizer rules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants