Skip to content

Refine Err propagation and avoid unwrap in transform closures #4318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2022
Merged

Refine Err propagation and avoid unwrap in transform closures #4318

merged 1 commit into from
Nov 22, 2022

Conversation

@mingmwang
Copy link
Contributor

@mingmwang mingmwang commented Nov 22, 2022 •
edited by alamb
Loading

Which issue does this PR close?

re #4139

Rationale for this change

Allow error propagation in physical optimizers

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added core Core DataFusion crate physical-expr Changes to the physical-expr crates labels Nov 22, 2022
@mingmwang mingmwang mentioned this pull request Nov 22, 2022
Merged
alamb
alamb approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thank you @mingmwang

I am going to merge this one in as I think propagating errors is uncontroversial and this is likely blocking other PRs now (and I can imagine it collecting conflicts)

datafusion/core/src/physical_plan/rewrite.rs
fn transform<F>(self, op: &F) -> Result<Self>
where
F: Fn(Self) -> Option<Self>,
F: Fn(Self) -> Result<Option<Self>>,
Copy link
Contributor

@alamb alamb Nov 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alamb alamb merged commit 94cd982 into apache:master Nov 22, 2022
@ursabot
Copy link

ursabot commented Nov 22, 2022

Benchmark runs are scheduled for baseline = 7c07e4d and contender = 94cd982. 94cd982 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alamb alamb alamb approved these changes

Assignees

No one assigned

Labels

core Core DataFusion crate physical-expr Changes to the physical-expr crates

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mingmwang @ursabot @alamb