Refactor downcasting functions with downcastvalue macro and improve error handling of ListArray downcasting
#4313
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This is discussed in #3152.
Rationale for this change
This is the new PR of improving error handling for downcasting. In #4261 we found out that there is a
downcast_value!macro which also covers our casting functions. Implementingas_xxx_arrayfunction withdowncast_value!is nearly decided for now for future PRs. This PR is small compared to last two PR because I want to hear your feedback about if my implementation is correct/desired?What changes are included in this PR?
New function:
ListArraydowncasting parts where following lines are used:Are these changes tested?
These changes passed related tests.