Skip to content

Fix the percentile argument for ApproxPercentileCont must be Float64, not Decimal128(2, 1) #4228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 19, 2022
Merged

Fix the percentile argument for ApproxPercentileCont must be Float64, not Decimal128(2, 1) #4228

merged 5 commits into from
Nov 19, 2022

Conversation

@comphead
Copy link
Contributor

Which issue does this PR close?

Closes #4103 .

Rationale for this change

Fix the percentile argument for ApproxPercentileCont must be Float64, not Decimal128(2, 1)

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the logical-expr Logical plan and expressions label Nov 15, 2022
@comphead
Copy link
Contributor Author

@andygrove please check the PR

@andygrove
Copy link
Member

LGTM @comphead, but I think this PR also needs a unit test so that we don't have regressions in the future.

@github-actions github-actions bot added core Core DataFusion crate physical-expr Changes to the physical-expr crates labels Nov 17, 2022
@comphead
Merge branch 'master' into decimal_percentile
f879f3e 
# Conflicts:
#	datafusion/core/tests/sql/aggregates.rs
@comphead
Copy link
Contributor Author

comphead commented Nov 17, 2022 •
edited
Loading

@andygrove thanks, added test

alamb
alamb approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thanks @comphead

datafusion/physical-expr/src/aggregate/tdigest.rs
}

pub(crate) fn merge_sorted_f64(&self, sorted_values: &[f64]) -> TDigest {
dbg!(&sorted_values);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

datafusion/expr/src/type_coercion/aggregates.rs Outdated
Comment on lines 182 to 183
"The percentile argument for {:?} must be Float64, not {:?}.",
agg_fun, input_types[1]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"The percentile argument for {:?} must be Float64, not {:?}.",
agg_fun, input_types[1]
"Could not coerce the percent argument for {:?} to Float64. Was {:?}.",
agg_fun, input_types[1]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@alamb alamb merged commit 446c2ea into apache:master Nov 19, 2022
@alamb
Copy link
Contributor

alamb commented Nov 19, 2022

Thanks @comphead

@ursabot
Copy link

ursabot commented Nov 19, 2022

Benchmark runs are scheduled for baseline = 123ca22 and contender = 446c2ea. 446c2ea is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alamb alamb alamb approved these changes

Assignees

No one assigned

Labels

core Core DataFusion crate logical-expr Logical plan and expressions physical-expr Changes to the physical-expr crates

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The percentile argument for ApproxPercentileCont must be Float64, not Decimal128(2, 1)

4 participants

@comphead @andygrove @alamb @ursabot