Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI checks that we can serde all benchmark queries #4047

Merged
merged 5 commits into from
Nov 1, 2022

Conversation

andygrove
Copy link
Member

@andygrove andygrove commented Oct 31, 2022

Which issue does this PR close?

N/A

Rationale for this change

Ballista relies on the ability to serde all benchmark queries. These CI checks help ensure that DataFusion continues to support this.

What changes are included in this PR?

Are there any user-facing changes?

No

@andygrove
Copy link
Member Author

@avantgardnerio fyi

alamb
alamb previously approved these changes Nov 1, 2022
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find evidence that this test actually ran 🤔


/// CI checks
#[cfg(test)]
#[cfg(feature = "ci")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why feature gate this with ci? I would have thought

#[cfg(test)]

was sufficient.

Additionally, I couldn't find evidence that these new tests were actually run:

-*- mode: grep; default-directory: "~/Downloads/logs_52324/" -*-
Grep started at Tue Nov  1 12:19:52

rg -n -H --no-heading -e 'serde_q7' 

Grep finished with no matches found at Tue Nov  1 12:19:52

🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests rely on the data files existing in a path from TPCH_DATA env var, which is set in CI

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did look into using MemTable but we don't support serde with MemTable

@alamb alamb dismissed their stale review November 1, 2022 16:21

hit wrong button

@andygrove
Copy link
Member Author

I couldn't find evidence that this test actually ran thinking

Thanks for catching that! I pushed a commit to add these tests to the workflow

@andygrove
Copy link
Member Author

Verified that tests ran this time:

 test ci::serde_q1 ... ok
test ci::serde_q10 ... ok
test ci::serde_q11 ... ok
test ci::serde_q12 ... ok
test ci::serde_q13 ... ok
test ci::serde_q14 ... ok
test ci::serde_q15 ... ok
test ci::serde_q16 ... ignored
test ci::serde_q17 ... ok
test ci::serde_q18 ... ok
test ci::serde_q19 ... ok
test ci::serde_q2 ... ok
test ci::serde_q20 ... ok
test ci::serde_q21 ... ok
test ci::serde_q22 ... ok
test ci::serde_q3 ... ok
test ci::serde_q4 ... ok
test ci::serde_q5 ... ok
test ci::serde_q6 ... ok
test ci::serde_q7 ... ok
test ci::serde_q8 ... ok
test ci::serde_q9 ... ok

@andygrove andygrove merged commit 8c26530 into apache:master Nov 1, 2022
@andygrove andygrove deleted the ci-benchmark-serde branch November 1, 2022 18:00
@ursabot
Copy link

ursabot commented Nov 1, 2022

Benchmark runs are scheduled for baseline = 525ac45 and contender = 8c26530. 8c26530 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Dandandan pushed a commit to yuuch/arrow-datafusion that referenced this pull request Nov 5, 2022
* Add CI checks that we can serde all benchmark queries

* move all ci tests to separate module

* format

* run serde tests in CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants