-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI check to verify that benchmark queries return the expected results #4015
Conversation
b9e0fad
to
b9b1b75
Compare
ee7921d
to
84bb1c8
Compare
47c2dab
to
7917a63
Compare
|
||
# the release profile takes a long time to build so we can use this profile during development to save time | ||
# cargo build --profile release-nonlto | ||
[profile.release-nonlto] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI workflow uses this profile rather than release
to try and save some time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Benchmark runs are scheduled for baseline = d391b85 and contender = 6651070. 6651070 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #4016
Rationale for this change
I would like to test that the benchmarks are producing the correct results so that we catch regressions. Some of the queries are producing very wrong results.
What changes are included in this PR?
ci
feature to benchmark crate, which will verify results are correctOutput:
Are there any user-facing changes?