Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add right anti join support and support it in HashBuildProbeOrder #4011

Merged
merged 2 commits into from
Oct 30, 2022
Merged

Add right anti join support and support it in HashBuildProbeOrder #4011

merged 2 commits into from
Oct 30, 2022

Conversation

Dandandan
Copy link
Contributor

@Dandandan Dandandan commented Oct 29, 2022 •
edited
Loading

Which issue does this PR close?

Closes #3946

Rationale for this change

Possible performance / memory usage improvements when optimization kicks in.

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added core Core DataFusion crate logical-expr Logical plan and expressions optimizer Optimizer rules labels Oct 29, 2022
jackwener
jackwener approved these changes Oct 29, 2022
View reviewed changes
Copy link
Member

@jackwener jackwener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we add Integration test about Join?
I find there is just inner join in it.

datafusion/core/src/physical_plan/joins/hash_join.rs
@@ -789,7 +789,6 @@ fn build_join_indexes(
&keys_values,
*null_equals_null,
)? {
left_indices.append(i);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Dandandan
Copy link
Contributor Author

Dandandan commented Oct 29, 2022 •
edited
Loading

How about we add Integration test about Join? I find there is just inner join in it.

You mean with SQL tests, or something else? Semi and anti joins don't have specific syntax currently, but are used for correlated subqueries, EXISTS, etc.

The right semi and right Anti are not used that often as they depend on statistics to be available. In Ballista I recently added support for a simple version of adaptive query execution. Now joins are reordered based on statistics that are collected when each stage has finished.

@Dandandan Dandandan merged commit d6f0b12 into apache:master Oct 30, 2022
@ursabot
Copy link

ursabot commented Oct 30, 2022

Benchmark runs are scheduled for baseline = 6651070 and contender = d6f0b12. d6f0b12 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

jimexist pushed a commit to jimexist/arrow-datafusion that referenced this pull request Oct 31, 2022
@Dandandan @jimexist
Add right anti join support and support it in HashBuildProbeOrder (ap…
bb6ffac 
…ache#4011)

* Add right anti join support

* Fix
Dandandan added a commit to yuuch/arrow-datafusion that referenced this pull request Nov 5, 2022
@Dandandan
Add right anti join support and support it in HashBuildProbeOrder (ap…
6356a21 
…ache#4011)

* Add right anti join support

* Fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackwener jackwener jackwener approved these changes

Assignees
No one assigned
Labels
core Core DataFusion crate logical-expr Logical plan and expressions optimizer Optimizer rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement right anti join and support it in HashBuildProbeOrder
3 participants
@Dandandan @ursabot @jackwener