fix: check recursion limit in Expr::to_bytes
#3970
Conversation
Install a DF-specific workaround until tokio-rs/prost#736 is implemented. Fixes apache#3968.
| // Need to provide some placeholder registry because the stream may contain UDFs | ||
| struct PlaceHolderRegistry; | ||
|
|
||
| impl FunctionRegistry for PlaceHolderRegistry { |
There was a problem hiding this comment.
I think the comments explain what is going on 👍
| // Need to provide some placeholder registry because the stream may contain UDFs | ||
| struct PlaceHolderRegistry; | ||
|
|
||
| impl FunctionRegistry for PlaceHolderRegistry { |
There was a problem hiding this comment.
I think the comments explain what is going on 👍
|
Benchmark runs are scheduled for baseline = 4ea970d and contender = 366e610. 366e610 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Install a DF-specific workaround until tokio-rs/prost#736 is implemented. Fixes apache#3968.
Install a DF-specific workaround until tokio-rs/prost#736 is implemented. Fixes apache#3968.
Which issue does this PR close?
Closes #3968.
Rationale for this change
Expr::to_bytescan create outputs thatExpr::from_bytescan no longer read.What changes are included in this PR?
Try to deserialize the data in
Expr::to_bytesto catch invalid data early. This is a workaround until tokio-rs/prost#736 is implemented.Are there any user-facing changes?
Expressions that are nested too deeply are now rejected to serialization already.