Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: Add some docstrings to FileScanConfig and RuntimeEnv #3962

Merged
merged 2 commits into from
Oct 28, 2022
Merged

Minor: Add some docstrings to FileScanConfig and RuntimeEnv #3962

merged 2 commits into from
Oct 28, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Oct 25, 2022

I was reading this code and figured I would encode some of the knowledge I gained into docstrings for the future.

@alamb alamb requested a review from tustvold October 25, 2022 20:33
@github-actions github-actions bot added the core Core DataFusion crate label Oct 25, 2022
@alamb
Copy link
Contributor Author

alamb commented Oct 27, 2022

@metesynnada or @retikulum perhaps you might be willing to review this PR as well

@alamb @tustvold
fix grammar
06f1bc9 
Co-authored-by: Raphael Taylor-Davies <1781103+tustvold@users.noreply.github.com>
@alamb alamb merged commit ca42f4c into apache:master Oct 28, 2022
@ursabot
Copy link

ursabot commented Oct 28, 2022

Benchmark runs are scheduled for baseline = 01cf17d and contender = ca42f4c. ca42f4c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

jimexist pushed a commit to jimexist/arrow-datafusion that referenced this pull request Oct 31, 2022
@alamb @tustvold @jimexist
Minor: Add some docstrings to FileScanConfig and RuntimeEnv (apac…
45c0667 
…he#3962)

* Minor: Add some docstrings to FileScanConfig

* fix grammar

Co-authored-by: Raphael Taylor-Davies <1781103+tustvold@users.noreply.github.com>

Co-authored-by: Raphael Taylor-Davies <1781103+tustvold@users.noreply.github.com>
Dandandan pushed a commit to yuuch/arrow-datafusion that referenced this pull request Nov 5, 2022
@alamb @tustvold @Dandandan
Minor: Add some docstrings to FileScanConfig and RuntimeEnv (apac…
ce3f888 
…he#3962)

* Minor: Add some docstrings to FileScanConfig

* fix grammar

Co-authored-by: Raphael Taylor-Davies <1781103+tustvold@users.noreply.github.com>

Co-authored-by: Raphael Taylor-Davies <1781103+tustvold@users.noreply.github.com>
@alamb alamb deleted the alamb/docstrings branch August 8, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tustvold tustvold tustvold approved these changes

Assignees
No one assigned
Labels
core Core DataFusion crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alamb @ursabot @tustvold