Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate physical join code into datafusion/core/src/physical_plan/joins #3942

Merged
merged 5 commits into from
Oct 24, 2022
Merged

Consolidate physical join code into datafusion/core/src/physical_plan/joins #3942

merged 5 commits into from
Oct 24, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Oct 24, 2022

Which issue does this PR close?

Re #3941

Rationale for this change

I want to quickly find where all the join code is (so it is clearer what code needs to be changed) and keep the datafusion codebase cleaner

What changes are included in this PR?

  1. Consolidate physical join code into datafusion/core/src/physical_plan/joins following the model of aggregate code:
    https://github.com/apache/arrow-datafusion/tree/6e0097d35391fea0d57c1d2ecfdef18437f681f4/datafusion/core/src/physical_plan/aggregates and sorts https://github.com/apache/arrow-datafusion/tree/6e0097d35391fea0d57c1d2ecfdef18437f681f4/datafusion/core/src/physical_plan/sorts

Are there any user-facing changes?

No functional change intended, this is just a "make the code easier to work with" proposal

@alamb alamb requested a review from Dandandan October 24, 2022 16:00
@github-actions github-actions bot added the core Core DataFusion crate label Oct 24, 2022
@alamb
Copy link
Contributor Author

alamb commented Oct 24, 2022

Thank you for the review @xudong963 !

@alamb alamb merged commit ff8618a into apache:master Oct 24, 2022
@ursabot
Copy link

ursabot commented Oct 25, 2022

Benchmark runs are scheduled for baseline = 9595b8d and contender = ff8618a. ff8618a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Dandandan pushed a commit to yuuch/arrow-datafusion that referenced this pull request Nov 5, 2022
@alamb @Dandandan
Consolidate physical join code into `datafusion/core/src/physical_pla…
1a43e84 
…n/joins` (apache#3942)

* Consolidate physical join code into `datafusion/core/src/physical_plan/joins`

* Update

* Update `use` paths

* Add RAT
@alamb alamb deleted the alamb/consolidate_physical_join_plans branch August 8, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xudong963 xudong963 xudong963 approved these changes

@andygrove andygrove andygrove approved these changes

@Dandandan Dandandan Awaiting requested review from Dandandan

Assignees
No one assigned
Labels
core Core DataFusion crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alamb @ursabot @andygrove @xudong963