Skip to content

Conversation

@Dandandan
Copy link
Contributor

@Dandandan Dandandan commented Oct 15, 2022

Which issue does this PR close?

Closes #3847

Rationale for this change

We would like to have a way to enable the collection of statistics.

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the core Core DataFusion crate label Oct 15, 2022
@Dandandan Dandandan marked this pull request as ready for review October 15, 2022 21:03
@isidentical
Copy link
Contributor

Looks great! Should we also document it somewhere since this seems like an important feature to accidentally miss out? (Or maybe on a subsequent PR we can try to enable this by default for 'local' parquet files, as per #3774).

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think ./dev/update_config_docs.sh will update the the configuration docs

I will run that as a follow on PR

@alamb alamb merged commit 6e56897 into apache:master Oct 18, 2022
@alamb
Copy link
Contributor

alamb commented Oct 18, 2022

#3877

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add collect statistics configuration

3 participants