Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run all datafusion-examples in CI tests #3761

Merged
merged 9 commits into from
Oct 12, 2022
Merged

Run all datafusion-examples in CI tests #3761

merged 9 commits into from
Oct 12, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Oct 7, 2022

Which issue does this PR close?

re #3740

Rationale for this change

We already check they compile as part of other tests, but we don't check they run without an error

What changes are included in this PR?

run more of the examples in the test CI job

Are there any user-facing changes?

No

@alamb alamb mentioned this pull request Oct 7, 2022
Closed
5 tasks
alamb
alamb commented Oct 7, 2022
View reviewed changes
datafusion-examples/examples/parquet_sql_multiple_files.rs
FROM alltypes_plain \
WHERE id > 1 AND tinyint_col < double_col",
"SELECT * \
FROM my_table \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The table was called "my_table" but the query referred to something else 😆

@alamb alamb requested a review from Dandandan October 11, 2022 17:45
@alamb alamb changed the title Run more datafusion-examples in CI tests Run all datafusion-examples in CI tests Oct 12, 2022
andygrove
andygrove approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andygrove andygrove merged commit 7179c54 into apache:master Oct 12, 2022
@alamb alamb deleted the alamb/example_ci branch October 12, 2022 20:18
@ursabot
Copy link

ursabot commented Oct 12, 2022

Benchmark runs are scheduled for baseline = 4cb8ac0 and contender = 7179c54. 7179c54 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andygrove andygrove andygrove approved these changes

@Dandandan Dandandan Awaiting requested review from Dandandan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alamb @ursabot @andygrove