Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove type coercion for physical ScalarFunction #3749

Merged
merged 2 commits into from
Oct 10, 2022
Merged

remove type coercion for physical ScalarFunction #3749

merged 2 commits into from
Oct 10, 2022

Conversation

liukun4515
Copy link
Contributor

Which issue does this PR close?

Closes #3731

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

liukun4515
liukun4515 commented Oct 7, 2022
View reviewed changes
datafusion/physical-expr/src/functions.rs
@@ -58,23 +58,20 @@ pub fn create_physical_expr(
input_schema: &Schema,
execution_props: &ExecutionProps,
) -> Result<Arc<dyn PhysicalExpr>> {
let coerced_phy_exprs =
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove type coercion in the physical phase

liukun4515
liukun4515 commented Oct 7, 2022
View reviewed changes
datafusion/optimizer/src/type_coercion.rs
@@ -310,18 +310,6 @@ impl ExprRewriter for TypeCoercionRewriter {
};
Ok(expr)
}
Expr::ScalarUDF { fun, args } => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just move these code

@liukun4515 liukun4515 requested review from alamb and andygrove and removed request for alamb October 7, 2022 03:31
@alamb alamb changed the title move type coercion for ScalarFunction remove type coercion for ScalarFunction Oct 7, 2022
@alamb alamb changed the title remove type coercion for ScalarFunction remove type coercion for physical ScalarFunction Oct 7, 2022
@alamb
Copy link
Contributor

alamb commented Oct 7, 2022

The CI checks appear to be failing

@github-actions github-actions bot added optimizer Optimizer rules physical-expr Physical Expressions labels Oct 8, 2022
@liukun4515
Copy link
Contributor Author

liukun4515 commented Oct 8, 2022 •
edited
Loading

The CI checks appear to be failing

Some errors about import in the test, I have fixed them

PTAL @alamb

@liukun4515
Copy link
Contributor Author

I will merge it first, and not block the follow-up pr.
If you have comments, I can fix them in the other pr. @alamb

@liukun4515 liukun4515 merged commit a92119a into apache:master Oct 10, 2022
@liukun4515 liukun4515 deleted the issue_#3731 branch October 10, 2022 12:48
@ursabot
Copy link

ursabot commented Oct 10, 2022

Benchmark runs are scheduled for baseline = e54110f and contender = a92119a. a92119a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

andygrove
andygrove reviewed Oct 10, 2022
View reviewed changes
Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @liukun4515

alamb
alamb reviewed Oct 11, 2022
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thanks @liukun4515

datafusion/physical-expr/src/functions.rs
@@ -2872,4 +2874,17 @@ mod tests {

Ok(())
}

// Helper function
// The type coercion will be done in the logical phase, should do the type coercion for the test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

BTW this is basically what I need to do in IOx / why I made #3708

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andygrove andygrove andygrove left review comments

@alamb alamb alamb left review comments

Assignees
No one assigned
Labels
optimizer Optimizer rules physical-expr Physical Expressions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support type coercion for ScalarFunction expr in the logical phase
4 participants
@liukun4515 @alamb @ursabot @andygrove