Skip to content

Conversation

@jonmmease
Copy link
Contributor

Which issue does this PR close?

Closes #3281

Rationale for this change

Fix SchemaError

What changes are included in this PR?

This change here was initially proposed in #1781, but was removed during review since there wasn't a known situation (or test) that required it. The new test, union_all_on_projection, fails without this change.

Are there any user-facing changes?

No

@github-actions github-actions bot added the optimizer Optimizer rules label Aug 27, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2022

Codecov Report

Merging #3282 (37aba41) into master (3d37016) will increase coverage by 0.07%.
The diff coverage is 100.00%.

❗ Current head 37aba41 differs from pull request most recent head 233e42e. Consider uploading reports for the commit 233e42e to get more accurate results

@@            Coverage Diff             @@
##           master    #3282      +/-   ##
==========================================
+ Coverage   85.74%   85.81%   +0.07%     
==========================================
  Files         294      294              
  Lines       53770    53775       +5     
==========================================
+ Hits        46104    46148      +44     
+ Misses       7666     7627      -39     
Impacted Files Coverage Δ
datafusion/core/tests/sql/timestamp.rs 99.65% <ø> (-0.01%) ⬇️
datafusion/optimizer/src/filter_push_down.rs 98.38% <100.00%> (+0.02%) ⬆️
datafusion/physical-expr/src/planner.rs 96.05% <100.00%> (+0.74%) ⬆️
datafusion/sql/src/planner.rs 80.46% <100.00%> (-0.16%) ⬇️
datafusion/expr/src/logical_plan/plan.rs 78.39% <0.00%> (+0.16%) ⬆️
datafusion/core/src/physical_plan/metrics/value.rs 87.43% <0.00%> (+0.50%) ⬆️
...tafusion/optimizer/src/common_subexpr_eliminate.rs 94.38% <0.00%> (+1.53%) ⬆️
datafusion/expr/src/expr_rewriter.rs 86.66% <0.00%> (+2.91%) ⬆️
datafusion/expr/src/expr.rs 84.92% <0.00%> (+6.95%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great -- thank you @jonmmease

I apologize for the late review. 🙏

@alamb alamb merged commit e3f412c into apache:master Sep 3, 2022
@ursabot
Copy link

ursabot commented Sep 3, 2022

Benchmark runs are scheduled for baseline = 7a53872 and contender = e3f412c. e3f412c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

jonmmease added a commit to vega/vegafusion that referenced this pull request Sep 3, 2022
kmitchener pushed a commit to kmitchener/arrow-datafusion that referenced this pull request Sep 4, 2022
…#3282)

* Add failing union_all_on_projection test

* Update projection step to replace both qualified and unqualified columns

* Remove redundant clone
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

optimizer Optimizer rules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FilterPushDown optimization through UNION ALL results in SchemaError

4 participants