Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test optional features in CI #2708

Merged
merged 3 commits into from
Jun 7, 2022
Merged

Conversation

tustvold
Copy link
Contributor

@tustvold tustvold commented Jun 7, 2022

Which issue does this PR close?

Closes #.

Rationale for this change

We weren't testing the optional features in CI, allowing regressions to creep in.

What changes are included in this PR?

Checks that all code compiles, and run tests for all features supported on stable.

Are there any user-facing changes?

No

Fix parquet SQL benchmarks
@github-actions github-actions bot added the core Core DataFusion crate label Jun 7, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2022

Codecov Report

Merging #2708 (c6bad3f) into master (1cd6ede) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

❗ Current head c6bad3f differs from pull request most recent head 6f5634b. Consider uploading reports for the commit 6f5634b to get more accurate results

@@            Coverage Diff             @@
##           master    #2708      +/-   ##
==========================================
- Coverage   84.67%   84.64%   -0.03%     
==========================================
  Files         270      270              
  Lines       46919    46930      +11     
==========================================
- Hits        39727    39726       -1     
- Misses       7192     7204      +12     
Impacted Files Coverage Δ
datafusion/core/benches/parquet_query_sql.rs 0.00% <ø> (ø)
datafusion/core/src/scheduler/mod.rs 0.00% <ø> (ø)
...physical-expr/src/expressions/get_indexed_field.rs 92.93% <0.00%> (-1.03%) ⬇️
datafusion/proto/src/from_proto.rs 33.79% <0.00%> (-0.32%) ⬇️
datafusion/proto/src/to_proto.rs 56.23% <0.00%> (-0.10%) ⬇️
datafusion/core/src/physical_plan/metrics/value.rs 86.93% <0.00%> (-0.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cd6ede...6f5634b. Read the comment docs.

@tustvold tustvold merged commit a6e93a1 into apache:master Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants