MINOR: Refactor datafusion-proto dependencies and imports
#2623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
changed the title
datafusion-proto dependencies and imports
alamb
approved these changes
May 26, 2022
There was a problem hiding this comment.
makes sense to me -- thank you for all your work to untangle the crates @andygrove ❤️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
This PR adds specific dependencies on
datafusion-commonanddatafusion-exprand updates the imports to reference those crates directly rather than use the re-exports from the coredatafusioncrate.The implementation of
datafusion-protonow only depends on a single item from the core crate and that isFunctionRegistry. We could potentially move this out in the future so that other projects can usedatafusion-protowithout depending on the core crate.The tests still depend heavily on the core crate.
What changes are included in this PR?
Add new dependencies in Cargo.toml and refactor the imports
Are there any user-facing changes?
No
Does this PR break compatibility with Ballista?
No