WIP: Remove duplicate datafusion.proto file and use more appropriate Java package names
#2515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
changed the title
datafusion.proto file and use more appropriate Java package names
alamb
approved these changes
May 11, 2022
datafusion-cli/Cargo.lock
Outdated
| @@ -1,2531 +0,0 @@ | |||
| # This file is automatically @generated by Cargo. | |||
There was a problem hiding this comment.
I think the idea behind this file was to allow datafusion-cli to be built by itself. #2112 by @happysalada
However, I agree it is getting annoying in my local checkout as well (seems to change regularly)
There was a problem hiding this comment.
Oh, I did not mean to delete this file. I think we want to keep lock files for binaries.
|
Failing on AMD64 with |
thinkharderdev
approved these changes
May 12, 2022
andygrove
changed the title
datafusion.proto file and use more appropriate Java package namesdatafusion.proto file and use more appropriate Java package names
|
Moving to draft so we don't merge before 8.0.0 PR is merged |
|
I think we might be able to merge this PR now |
Ted-Jiang
approved these changes
May 18, 2022
|
Now that ballista is in the new repo I will open a PR over there instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2513 and #2514
Rationale for this change
No need to have two copies of the same source file
What changes are included in this PR?
Are there any user-facing changes?
Yes, for java users using these .proto files