Skip to content

Conversation

@andygrove
Copy link
Member

Which issue does this PR close?

Closes #2424

Rationale for this change

Make the project more consistent. All of the other datafusion sub-crates are under the datafusion directory and there appears to be no reason for data-access to be different.

What changes are included in this PR?

  • Move data-access crate into datafusion directory
  • Bump data-access version from 1.0.0 to 7.0.0 for consistency with other crates
  • Update release scripts

Are there any user-facing changes?

No

@andygrove andygrove added the development-process Related to development process of DataFusion label May 7, 2022
@andygrove andygrove self-assigned this May 7, 2022
@jychen7
Copy link
Contributor

jychen7 commented May 8, 2022

nice, LGTM

@yahoNanJing
Copy link
Contributor

yahoNanJing commented May 9, 2022

Hi @andygrove, according to #2076, the reason to move the data-access crate out of the datafusion directory is to make it possible for other crates, like datafusion-objectstore-s3 and datafusion-objectstore-hdfs, to depend on only this crate rather than the whole datafusion crate. Then the datafusion crate may also be able to depend on the object store extensions.

In summary, the data-access crate should not depend on the datafusion. The dependencies should be like follows:

datafusion
     |        \
     |          \
     |            datafusion-objectstore-extensions
     |            /
     |          /
data-access

In the future, it's better for the data-access crate to act as an independent crate. Therefore, it's better not to move it to the datafusion directory.

@jychen7
Copy link
Contributor

jychen7 commented May 9, 2022

it looks like this PR just change the data-access code location (for easier crate building). So it doesn't change dependencies

@andygrove andygrove force-pushed the move-data-access-crate branch from c6def36 to f5cf3a2 Compare May 10, 2022 15:50
@andygrove
Copy link
Member Author

it looks like this PR just change the data-access code location (for easier crate building). So it doesn't change dependencies

Yes, that is correct. This PR just moves the code and bumps the version from 1.0.0 to 7.0.0 for consistency with other DataFusion crates.

@andygrove
Copy link
Member Author

Thanks for the review @yjshen

@andygrove andygrove merged commit 101671e into apache:master May 11, 2022
@andygrove andygrove deleted the move-data-access-crate branch May 11, 2022 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development-process Related to development process of DataFusion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move data-access crate to same level as other crates?

4 participants