Benchmark for sort preserving merge #2431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
force-pushed
the
alamb/merge_benchmark
branch
from
b198895
to
4e6d284
Compare
alamb
force-pushed
the
alamb/merge_benchmark
branch
from
aaacfe9
to
fc5f039
Compare
alamb
force-pushed
the
alamb/merge_benchmark
branch
from
fc5f039
to
5b6e9c5
Compare
alamb
changed the title
andygrove
reviewed
May 20, 2022
Comment on lines
+32
to
+67
| //! Rows are randombly | ||
| //! divided into separate | ||
| //! RecordBatch "streams", | ||
| //! ┌────┐ ┌────┐ ┌────┐ preserving the order ┌────┐ ┌────┐ ┌────┐ | ||
| //! │ │ │ │ │ │ │ │ │ │ │ │ | ||
| //! │ │ │ │ │ │ ──────────────┐ │ │ │ │ │ │ | ||
| //! │ │ │ │ │ │ └─────────────▶ │ C1 │ │... │ │ CN │ | ||
| //! │ │ │ │ │ │ ───────────────┐ │ │ │ │ │ │ | ||
| //! │ │ │ │ │ │ ┌┼─────────────▶ │ │ │ │ │ │ | ||
| //! │ │ │ │ │ │ ││ │ │ │ │ │ │ | ||
| //! │ │ │ │ │ │ ││ └────┘ └────┘ └────┘ | ||
| //! │ │ │ │ │ │ ││ ┌────┐ ┌────┐ ┌────┐ | ||
| //! │ │ │ │ │ │ │└───────────────▶│ │ │ │ │ │ | ||
| //! │ │ │ │ │ │ │ │ │ │ │ │ │ | ||
| //! │ │ │ │ │ │ ... │ │ C1 │ │... │ │ CN │ | ||
| //! │ │ │ │ │ │ ──────────────┘ │ │ │ │ │ │ | ||
| //! │ │ │ │ │ │ ┌──────────────▶ │ │ │ │ │ │ | ||
| //! │ C1 │ │... │ │ CN │ │ │ │ │ │ │ │ | ||
| //! │ │ │ │ │ │───────────────┐│ └────┘ └────┘ └────┘ | ||
| //! │ │ │ │ │ │ ││ | ||
| //! │ │ │ │ │ │ ││ | ||
| //! │ │ │ │ │ │ ││ ... | ||
| //! │ │ │ │ │ │ ────────────┼┼┐ | ||
| //! │ │ │ │ │ │ │││ | ||
| //! │ │ │ │ │ │ │││ ┌────┐ ┌────┐ ┌────┐ | ||
| //! │ │ │ │ │ │ ──────────────┼┘│ │ │ │ │ │ │ | ||
| //! │ │ │ │ │ │ │ │ │ │ │ │ │ │ | ||
| //! │ │ │ │ │ │ │ │ │ C1 │ │... │ │ CN │ | ||
| //! │ │ │ │ │ │ └─┼────────────▶ │ │ │ │ │ │ | ||
| //! │ │ │ │ │ │ │ │ │ │ │ │ │ | ||
| //! │ │ │ │ │ │ └─────────────▶ │ │ │ │ │ │ | ||
| //! └────┘ └────┘ └────┘ └────┘ └────┘ └────┘ | ||
| //! Input RecordBatch NUM_STREAMS input | ||
| //! Columns 1..N RecordBatches | ||
| //! INPUT_SIZE sorted rows (still INPUT_SIZE total | ||
| //! ~10% duplicates rows) |
andygrove
approved these changes
May 20, 2022
|
Thanks @andygrove |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #2427
Rationale for this change
Add benchmarks for the cases I intended to optimize for in #2427
What changes are included in this PR?
new
mergebenchmarkrun:
Here is an example flamegraph produced via:
Are there any user-facing changes?
No