Skip to content

chore: Unbreak doctest CI#20218

Merged
Jefffrey merged 1 commit intoapache:mainfrom
neilconway:neilc/doctest-upgrading-fix
Feb 8, 2026
Merged

chore: Unbreak doctest CI#20218
Jefffrey merged 1 commit intoapache:mainfrom
neilconway:neilc/doctest-upgrading-fix

Conversation

@neilconway
Copy link
Contributor

@neilconway neilconway commented Feb 8, 2026

File was renamed and split into smaller files as part of #20183.

Rationale for this change

CI is failing with:

   Doc-tests datafusion
error: couldn't read `datafusion/core/src/../../../docs/source/library-user-guide/upgrading.md`: No such file or directory (os error 2)
    --> datafusion/core/src/lib.rs:1182:1
     |
1182 | / doc_comment::doctest!(
1183 | |     "../../../docs/source/library-user-guide/upgrading.md",
1184 | |     library_user_guide_upgrading
1185 | | );
     | |_^
     |
     = note: this error originates in the macro `include_str` which comes from the expansion of the macro `doc_comment::doctest` (in Nightly builds, run with -Z macro-backtrace for more info)

What changes are included in this PR?

File was renamed and split into smaller files as part of apache#20183.
@github-actions github-actions bot added the core Core DataFusion crate label Feb 8, 2026
@neilconway
Copy link
Contributor Author

Note that there are still various references to a file called upgrading.md in the source tree; I haven't attempted to fix all those as part of this PR.

$ ag upgrading.md | wc -l
      31

@neilconway
Copy link
Contributor Author

PTAL @avantgardnerio @alamb

@Jefffrey Jefffrey added this pull request to the merge queue Feb 8, 2026
Merged via the queue into apache:main with commit 4f4b0b5 Feb 8, 2026
29 checks passed
@Jefffrey
Copy link
Contributor

Jefffrey commented Feb 8, 2026

Thanks @neilconway, merged to unbreak CI

Note that there are still various references to a file called upgrading.md in the source tree; I haven't attempted to fix all those as part of this PR.

This would be good to address in a followup 👍

@neilconway neilconway deleted the neilc/doctest-upgrading-fix branch February 8, 2026 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants