Document the relationship between FileFormat::projection / FileFormat::filter and FileScanConfig::output_ordering#20196
Open
alamb wants to merge 2 commits intoapache:mainfrom
Open
Document the relationship between FileFormat::projection / FileFormat::filter and FileScanConfig::output_ordering#20196alamb wants to merge 2 commits intoapache:mainfrom
alamb wants to merge 2 commits intoapache:mainfrom
Conversation
…::filter and FileScanConfig::output_ordering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
FileFormat::projection/FileFormat::filterandFileScanConfig::Statistics#20188Rationale for this change
I spent a long time trying to figure out what was going on in our fork after
a DataFusion 52 upgrade, and the root cause was that the output_ordering in DataFusion
52 does NOT include the projection (more details here #20173 (comment))
This was not clear to me from the DataFusion code or documentation, and I think
it would be helpful to clarify this in the documentation.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?