Skip to content

Refactor Spark date_add/date_sub/bitwise_not to remove unnecessary scalar arg check #19473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Jefffrey wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Refactor Spark date_add/date_sub/bitwise_not to remove unnecessary scalar arg check #19473

Jefffrey wants to merge 2 commits into from
+7 −100

Conversation

@Jefffrey
Copy link
Contributor

@Jefffrey Jefffrey commented Dec 24, 2025

Same as #19466 but for date_add, date_sub and bitwise_not

If we have a scalar argument that is null, that means the datatype it is from is already nullable, so theres no need to check both; we only need to check the nullability of the datatype

@github-actions github-actions bot added the spark label Dec 24, 2025
@Jefffrey Jefffrey marked this pull request as ready for review December 24, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

spark

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Jefffrey