Enable Parallel Aggregation for Non-Overlapping Partitioned Data#18826
Closed
gene-bordegaray wants to merge 3 commits intoapache:mainfrom
Closed
Conversation
78e9af0 to
be508b7
Compare
48b2e63 to
57aa0f1
Compare
Contributor
Author
|
cc: @NGA-TRAN |
Contributor
|
Thanks @gene-bordegaray — impressive performance improvement! I’ll plan to review this during the first week of December. Adding a feature design description to the PR would be helpful for context. If you identify any follow‑up work, feel free to open tickets, link this PR there, and continue working on next PRs on top of this branch. |
46 tasks
37 tasks
57aa0f1 to
09f9570
Compare
e55b75c to
e7a2812
Compare
e7a2812 to
5bcded3
Compare
Contributor
Author
|
I am going to close this PR and open a new one with my refactored apporach and cleaner history See here: #18919 |
42 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will finish later
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Benchmark results:
TPCH remains unchange as expected since the files don't use Hive-Partitioning
I created my own benchmark using partitioned by partitioning spf1 and spf10 benches to use the optimizations. This benchmark ran the query:
Are there any user-facing changes?