Consolidate sql operations examples (#18142) #18743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
High-Level OverviewThis PR consolidates all cargo run --example sql_ops -- [analysis|dialect|frontend|query] |
2010YOUY01
approved these changes
Nov 17, 2025
Contributor
2010YOUY01
left a comment
2010YOUY01
left a comment
There was a problem hiding this comment.
LGTM, thank you so much!
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| //! This example shows how to use the structures that DataFusion provides to perform |
Contributor
There was a problem hiding this comment.
Suggested change
| //! See `main.rs` for how to run it. | |
| //! | |
| //! This example shows how to use the structures that DataFusion provides to perform |
I just recently got slightly confused about how to run this new example setup, hope this can help.
Contributor
Author
There was a problem hiding this comment.
This is a good point - I added this
Contributor
Author
There was a problem hiding this comment.
After we finish with consolidating all examples, I'm going to work on this ##18529 to simplify working with examples
xudong963
approved these changes
Nov 17, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 17, 2025
## Which issue does this PR close? Related to #18142 and #18743 ## Rationale for this change The catalog examples were moved under `datafusion-examples/examples/data_io/`, but the doc comments and user guide still point to the old paths. This leaves readers with 404s when they try to follow the examples, so the links need to be corrected. ## What changes are included in this PR? Correct the catalog example links so they point to the examples/data_io directory.
logan-keede
pushed a commit
to logan-keede/datafusion
that referenced
this pull request
Nov 23, 2025
## Which issue does this PR close? Related to apache#18142 and apache#18743 ## Rationale for this change The catalog examples were moved under `datafusion-examples/examples/data_io/`, but the doc comments and user guide still point to the old paths. This leaves readers with 404s when they try to follow the examples, so the links need to be corrected. ## What changes are included in this PR? Correct the catalog example links so they point to the examples/data_io directory.
logan-keede
pushed a commit
to logan-keede/datafusion
that referenced
this pull request
Nov 23, 2025
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes apache#123` indicates that this PR will close issue apache#123. --> - part of #apache#18142. ## Rationale for this change This PR is for consolidating all the `sql_ops` examples (analysis, dialect, frontend, query) into a single example binary. We are agreed on the pattern and we can apply it to the remaining examples <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> --------- Co-authored-by: Sergey Zhukov <szhukov@aligntech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
This PR is for consolidating all the
sql_opsexamples (analysis, dialect, frontend, query) into a single example binary. We are agreed on the pattern and we can apply it to the remaining examplesWhat changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?