Consolidate ArrowFileSource and ArrowStreamFileSource #18720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriangb
force-pushed
the
projection-source-arrow
branch
from
05411eb to
c76595f
Compare
This commit consolidates the separate ArrowFileSource and ArrowStreamFileSource implementations into a unified ArrowSource with an ArrowFormat enum. Key changes: - Removed ArrowFileSource and ArrowStreamFileSource structs - Added ArrowFormat enum (File, Stream) to distinguish between formats - Created unified ArrowSource struct that uses ArrowFormat to dispatch - Kept separate ArrowFileOpener and ArrowStreamFileOpener implementations - Consolidated all FileSource trait implementations in ArrowSource - Format-specific behavior in repartitioned() method (Stream returns None) This consolidation reduces code duplication while maintaining clear separation of concerns between the file and stream format handling. Part of apache#18627 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
adriangb
force-pushed
the
projection-source-arrow
branch
from
c76595f to
3990945
Compare
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR consolidates the separate
ArrowFileSourceandArrowStreamFileSourceimplementations into a unifiedArrowSourcewith anArrowFormatenum.This is part of the larger projection refactoring effort tracked in #18627.
Key Changes
ArrowFileSourceandArrowStreamFileSourceimplementationsArrowFormatenum: Simple enum withFileandStreamvariants to distinguish between Arrow IPC formatsArrowSourcestruct: Single struct that usesArrowFormatto dispatch to appropriate openerArrowFileOpenerandArrowStreamFileOpenerremain distinct as their implementations differ significantlyrepartitioned()method returnsNonefor Stream format (doesn't support parallel reading) and delegates to default logic for File formatBenefits
Testing
Related Work
This PR is independent and can be merged before or after:
Part of #18627
🤖 Generated with Claude Code