[branch-50] Backport: More decimal 32/64 support#17908
Closed
AdamGS wants to merge 2 commits intoapache:branch-50from
Closed
[branch-50] Backport: More decimal 32/64 support#17908AdamGS wants to merge 2 commits intoapache:branch-50from
AdamGS wants to merge 2 commits intoapache:branch-50from
Conversation
github-actions
bot
added
sql
Contributor
Author
|
@alamb this is the best way I figured out to set up the changes across repos, seems like pointing the PR at the intermediate branch did not make the followup point to |
22 tasks
* Support Decimal32/64 types * Fix bugs, tests, handle more aggregate functions and schema * Fill out more parts in expr,common and expr-common * Some stragglers and overlooked corners * Actually commit the avg_distinct support --------- Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
* More small decimal support * CR comments Co-authored-by: Jeffrey Vo <jeffrey.vo.australia@gmail.com> * Add tests and cleanup some code --------- Co-authored-by: Jeffrey Vo <jeffrey.vo.australia@gmail.com>
AdamGS
force-pushed
the
adamg/backport-17808
branch
from
6db35d5 to
74ea1d5
Compare
Contributor
Author
|
See #17907 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
50.2.0(minor) #17849Rationale for this change
Fills up decimal32/64 support as introduced in #17501
What changes are included in this PR?
The biggest change in this PR is that type coercion for binary expression now not only supports the new decimal types, but it will try and extend one side into the other, which would just fail right now.
Minor changes
abs(deicmal32/64)Are these changes tested?
Additional coercion tests
Are there any user-facing changes?
No public API changes, but more combination of operations should work.