[branch-50] fix: Implement AggregateUDFImpl::reverse_expr for StringAgg (#17165) #17473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…7165) * fix: Implement AggregateUDFImpl::reverse_expr for StringAgg * Add a test with two invocations of aggregateion --------- Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
github-actions
bot
added
sqllogictest
Contributor
|
Filed discussion https://github.com/orgs/community/discussions/172811 |
Contributor
Author
|
Thanks @comphead and @nuno-faria |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
50.0.0(Aug/Sep 2025) #16799string_aggdoes not respectORDER BYon49.0.0#17011Rationale for this change
I believe the change in #17165 is needed to prevent a regression in DataFusion 50 (as we backported a bug fix to 49, but the code had changed on master)
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?