Skip to content

minor: make dict_from_values public #17376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 4, 2025
Merged

minor: make dict_from_values public #17376

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c8ddec2
minor: make dict_from_values public
parthchandra Sep 1, 2025
3fe1f9f
Update datafusion/common/src/scalar/mod.rs
parthchandra Sep 3, 2025
688c515
fix format
parthchandra Sep 3, 2025
0f31ac8
one more format
parthchandra Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions datafusion/common/src/scalar/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -881,8 +881,21 @@ fn dict_from_scalar<K: ArrowDictionaryKeyType>(
))
}

/// Create a dictionary array representing all the values in values
fn dict_from_values<K: ArrowDictionaryKeyType>(
/// Create a `DictionaryArray` from the provided values array.
///
/// Each element gets a unique key (`0..N-1`), without deduplication.
/// Useful for wrapping arrays in dictionary form.
///
/// # Input
/// ["alice", "bob", "alice", null, "carol"]
///
/// # Output
/// `DictionaryArray<Int32>`
/// {
/// keys: [0, 1, 2, 3, 4],
/// values: ["alice", "bob", "alice", null, "carol"]
/// }
pub fn dict_from_values<K: ArrowDictionaryKeyType>(
values_array: ArrayRef,
) -> Result<ArrayRef> {
// Create a key array with `size` elements of 0..array_len for all
Expand Down