Implement Helpers for ScopedTimerGuard and Time Structs #16911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
adriangb
pushed a commit
to pydantic/datafusion
that referenced
this pull request
Jul 28, 2025
* Update value.rs * Update value.rs * Update value.rs * Update datafusion/physical-plan/src/metrics/value.rs Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org> * Update datafusion/physical-plan/src/metrics/value.rs Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org> * Update datafusion/physical-plan/src/metrics/value.rs Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org> --------- Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Add methods to
TimeandScopedTimerGuardthat allow measuring elapsed time with custom start/end instants instead of relying onInstant::now().What changes are included in this PR?
timer_with(now: Instant)toTime- creates a timer starting from a specific instantstop_with(end_time: Instant)toScopedTimerGuard- stops timer with a custom end timedone_with(end_time: Instant)toScopedTimerGuard- stops timer with custom end time and consumes selfAre these changes tested?
Yes, unit tests are added
Are there any user-facing changes?