remove deprecated methods from FileScanConfig / DataSourceExec #16901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Jul 24, 2025
| } | ||
|
|
||
| /// Set the file source | ||
| #[deprecated(since = "47.0.0", note = "use FileScanConfigBuilder instead")] |
Contributor
There was a problem hiding this comment.
Technically speaking we should leave these methods until 53.0.0 per https://datafusion.apache.org/contributor-guide/api-health.html#deprecation-guidelines
However, given they are pretty low level (and thus I don't expect many actual users of them) and we are trying to work on this code for other reasons, I think it is fine to remove them early
Contributor
Author
Collaborator
|
would love to help! feel free ping in discord |
adriangb
added a commit
to pydantic/datafusion
that referenced
this pull request
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spoke with @alamb about continuing to refactor these traits with the goal of eventually getting projection pushdown.
We agreed tugging at loose ends of the knot is a good place to start, and removing deprecated methods is a good place to do so.