Support utf8view for spark hex #16885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhuqi-lucas
reviewed
Jul 24, 2025
| DataType::Utf8View => { | ||
| let array = as_string_view_array(array)?; | ||
|
|
||
| let hexed: StringArray = array |
Contributor
There was a problem hiding this comment.
Thanks @xudong963 , a minor question:
Here hexed is StringArray, why not using StringViewArray? Is it because we don't support it for the usage for this function?
It looks like the upper level spark don't support utf8view?
Member
Author
There was a problem hiding this comment.
I saw that the return type of the function is String https://docs.databricks.com/gcp/en/sql/language-manual/functions/hex#returns
Contributor
There was a problem hiding this comment.
I saw that the return type of the function is String https://docs.databricks.com/gcp/en/sql/language-manual/functions/hex#returns
Ok so the upstream looks like we should return string.
alamb
approved these changes
Jul 24, 2025
zhuqi-lucas
approved these changes
Jul 25, 2025
Member
Author
|
thanks all |
adriangb
pushed a commit
to pydantic/datafusion
that referenced
this pull request
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Yes
Are there any user-facing changes?