fix tests in page_pruning when filter pushdown is enabled by default#16794
Merged
alamb merged 2 commits intoapache:mainfrom Jul 16, 2025
Merged
fix tests in page_pruning when filter pushdown is enabled by default#16794alamb merged 2 commits intoapache:mainfrom
alamb merged 2 commits intoapache:mainfrom
Conversation
alamb
approved these changes
Jul 15, 2025
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Awesome -- thank you @XiangpengHao 🙏
xudong963
approved these changes
Jul 16, 2025
Contributor
|
Thank you @XiangpengHao and @xudong963 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This should unblock our way to enable filter pushdown by default.
Rationale for this change
When working on #16711 we keep getting the annoying test error because these two test cases are written without filter-pushdown in mind, i.e., the assertions of row counts are before filter is applied
This PR makes it more explicit what to expect with and without filter pushdown.
cc @alamb I think with this change we will get a green light in #16711
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?