fix: Fix CI failing due to #16686 #16718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@adriangb Just need a quick merge here 😆 |
adriangb
approved these changes
Jul 9, 2025
Contributor
|
Will merge once CI passes. Incidentally I was just working on HashJoinExec pushdown and think some of these APIs will need another tweak. Headed in the right direction but not quite there yet! At least now equivalence won't break going forward since it's tested. |
Contributor
|
Thanks for merging @xudong963 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Fix ci
What changes are included in this PR?
#16686 seems to have been merged with conflicts due to the refactor pushdown brought by #16642. A function was removed in the refactor, this just adds back the same functionality that was removed.
Are these changes tested?
Are there any user-facing changes?