Fix sqllogictests test running compatibility (ignore --test-threads)
#16694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sqllogictests.rs already has various parts of it's Options struct that provide compatibility with the standard test running options. Extend this to include the standard `--test-threads` option, so that running for example `cargo test -- --test-threads 1` in the project root will succeed. Previously it complained about the unknown option. This can be useful on a machine with a large number of cores which causes many tests to build & run in parallel, which in my case caused a crash due to exhausing the system RAM.
alamb
changed the title
--test-threads)
Make test-threads optional, so that the tests also pass when this is not passed in. 🤦
Contributor
|
Thanks again @mjgarton |
mjgarton
added a commit
to mjgarton/datafusion
that referenced
this pull request
Jul 9, 2025
Use the `test-threads` option in sqllogictests if it is passed in, instead of ignoring it. Default to using get_available_parallelism as before otherwise. Previously, this option was only added for compatability with the standard test runner, but was ignored. ( This change was suggested by @alanb : apache#16694 (comment) )
xudong963
pushed a commit
that referenced
this pull request
Jul 10, 2025
Use the `test-threads` option in sqllogictests if it is passed in, instead of ignoring it. Default to using get_available_parallelism as before otherwise. Previously, this option was only added for compatability with the standard test runner, but was ignored. ( This change was suggested by @alanb : #16694 (comment) )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sqllogictests.rs already has various parts of it's Options struct that provide compatibility with the standard test running options.
Extend this to include the standard
--test-threadsoption, so that running for examplecargo test -- --test-threads 1in the project root will succeed. Previously it complained about the unknown option.This can be useful on a machine with a large number of cores which causes many tests to build & run in parallel, which in my case caused a crash due to exhausing the system RAM.
Fixes #16693