Avoid treating incomparable scalars as equal #16624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
optimizer
Fix calls to `ScalarValue::partial_cmp` that treat `None` return value as equivalent to equality. The `partial_cmp` returns `None` when values cannot be compared, for example they have incompatible types. Apparently, in all these places it is an error condition when values cannot be compared.
findepi
force-pushed
the
findepi/avoid-treating-incomparable-scalars-as-equal-bed985
branch
from
6843dbb to
6d1654f
Compare
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
findepi
deleted the
findepi/avoid-treating-incomparable-scalars-as-equal-bed985
branch
jcsherin
added a commit
to jcsherin/datafusion
that referenced
this pull request
Nov 23, 2025
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix calls to
ScalarValue::partial_cmpthat treatNonereturn value as equivalent to equality. Thepartial_cmpreturnsNonewhen values cannot be compared, for example they have incompatible types. Apparently, in all these places it is an error condition when values cannot be compared.