Add support for Arrow Time types in Substrait #16558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkosh44
force-pushed
the
substrait-time
branch
2 times, most recently
from
5208dad to
6ec751d
Compare
Contributor
|
FYI @gabotechs |
gabotechs
approved these changes
Jun 26, 2025
Contributor
gabotechs
left a comment
gabotechs
left a comment
There was a problem hiding this comment.
💯 confirmed that this works now, thanks!
This commit adds support for Arrow Time types Time32 and Time64 in Substrait plans. Resolves apache#16296 Resolves apache#16275
alamb
approved these changes
Jul 1, 2025
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @jkosh44 and @gabotechs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
This commit adds support for Arrow Time types Time32 and Time64 in Substrait plans.
What changes are included in this PR?
Are these changes tested?
Yes
Are there any user-facing changes?
Add support for Arrow time types in Substrait plans