Skip to content

Add PhysicalExpr optimizer and cast unwrapping #16530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 2, 2025
Merged

Add PhysicalExpr optimizer and cast unwrapping #16530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6b2398a
Add PhysicalExpr optimizer and cast unwrapping
adriangb Jun 27, 2025
46d0e41
address pr feedback
adriangb Jul 1, 2025
e57e321
Update datafusion/pruning/src/pruning_predicate.rs
adriangb Jul 1, 2025
8cecdfc
more lit(Xi64)
adriangb Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions datafusion/datasource-parquet/src/opener.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ use arrow::datatypes::{FieldRef, SchemaRef, TimeUnit};
use arrow::error::ArrowError;
use datafusion_common::{exec_err, DataFusionError, Result};
use datafusion_datasource::PartitionedFile;
use datafusion_physical_expr::simplifier::PhysicalExprSimplifier;
use datafusion_physical_expr::PhysicalExprSchemaRewriter;
use datafusion_physical_expr_common::physical_expr::{
is_dynamic_physical_expr, PhysicalExpr,
Expand Down Expand Up @@ -233,7 +234,16 @@ impl FileOpener for ParquetOpener {
)
.rewrite(p)
.map_err(ArrowError::from)
.map(|p| {
// After rewriting to the file schema, further simplifications may be possible.
// For example, if `'a' = col_that_is_missing` becomes `'a' = NULL` that can then be simplified to `FALSE`
// and we can avoid doing any more work on the file (bloom filters, loading the page index, etc.).
PhysicalExprSimplifier::new(&physical_file_schema)
.simplify(p)
.map_err(ArrowError::from)
})
})
.transpose()?
.transpose()?;

// Build predicates for this specific file
Expand Down
Loading