Add spill_count and spilled_bytes to BaselineMetrics, test sort with spill
#1641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… spill of metrics
yjshen
changed the title
spill_count and spilled_bytes into BaselineMetrics, test sort with spillspill_count and spilled_bytes in BaselineMetrics, test sort with spill
yjshen
changed the title
spill_count and spilled_bytes in BaselineMetrics, test sort with spillspill_count and spilled_bytes to BaselineMetrics, test sort with spill
|
Hi @alamb, could you please help review this? |
liukun4515
reviewed
Jan 22, 2022
| Self::EndTimestamp(_) => 5, | ||
| Self::SpillCount(_) => 2, | ||
| Self::SpilledBytes(_) => 3, | ||
| Self::Count { .. } => 4, |
There was a problem hiding this comment.
It looks good to me, but we can make the format consistent with others as a minor fix in a follow-up pull request.
Self::Count { .. } => 4, -> Self::Count(_) => 4,
|
Thank you @yjshen and @liukun4515 for the review ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1611 and #1573 .
Rationale for this change
Report
spill_countandspilled_bytesinBaselineMetricssince these might be common metrics as we proceed with more memory consumers.We could also test sort spill with these newly introduced metrics.
What changes are included in this PR?
spill_countandspilled_bytesinBaselineMetricsAre there any user-facing changes?
No.