-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add design process section to the docs #16397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -108,6 +108,26 @@ Features above) prior to acceptance include: | |
[extensions list]: ../library-user-guide/extensions.md | ||
[design goal]: https://docs.rs/datafusion/latest/datafusion/index.html#design-goals | ||
|
||
### Design Build vs. Big Up Front Design | ||
|
||
Typically, the DataFusion community attacks large problems by solving them bit | ||
by bit and refining a solution iteratively on the `main` branch as a series of | ||
Pull Requests. This is different from projects which front-load the effort | ||
with a more comprehensive design process. | ||
|
||
By "advancing the front" the community always makes tangible progress, and the strategy is | ||
especially effective in a project that relies on individual contributors who may | ||
not have the time or resources to invest in a large upfront design effort. | ||
However, this "bit by bit approach" doesn't always succeed, and sometimes we get | ||
stuck or go down the wrong path and then change directions. | ||
|
||
Our process necessarily results in imperfect solutions being the "state of the | ||
code" in some cases, and larger visions are not yet fully realized. However, the | ||
community is good at driving things to completion in the long run. If you see | ||
something that needs improvement or an area that is not yet fully realized, | ||
please consider submitting an issue or PR to improve it. We are always looking | ||
for more contributions. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Of course we always have to be 🎣 |
||
|
||
# Developer's guide | ||
|
||
## Pull Request Overview | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wondering if this is needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the idea behind this sentence is to acknowledge the tradeoffs inherent in "design / build" vs "big design all upfront" (it is this tension that actually sparked the original comment in the first place))