Disable datafusion-cli tests for hash_collision tests, fix extended CI
#16382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
development-process
alamb
changed the title
alamb
changed the title
datafusion-cli tests for hash_collision tests, fix extended CI
THank you for agreeing. I have to admit it seems somewhat like cheating, but I still think it is true 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
As described on #16378, the
datafusion-clitests started failing after #16300 because now it tries to fetch credentials when creating a table (rather than just accessing it)It turns out that there is something in the github ci runner builder environment that triggers trying to fetch credentials from the AWS metastore which causes an error
Since the point of the hash collisions test is to verify that the core hash operators (hash join, merge join) don't get the wrong answers when there are hash collisions, there is no need to run the
datafusion-clitestsWhat changes are included in this PR?
Disable
datafusion-clitests as part of the extended suite (they are already run on normal CI jobs)Are these changes tested?
I tested it manually and it worked great
Are there any user-facing changes?