fix: create file for empty stream #16342
Open
+198
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
|
Maybe add same test for write_parquet and write_json? I think they should have same behavior. |
alamb
reviewed
Jun 11, 2025
There was a problem hiding this comment.
Thank you @chenkovsky -- the only question I have about this PR is how it works when writing partitioned output (aka into a directory).
The only thing I think the PR needs is a test showing what happens when writing to a directory.
I am not 100% sure what the expected behavior would be in this case, and I think either one is probably reasonable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
file won't be created for empty dataframe
What changes are included in this PR?
create file if row number is zero
Are these changes tested?
UT
Are there any user-facing changes?
No