fix: [branch-48] Revert "Improve performance of constant aggregate window expression" #16307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pache#16234)" This reverts commit 0c30374.
|
@alamb I have confirmed that reverting this change from branch-48 resolves the Comet issue |
github-actions
bot
added
the
development-process
This was referenced Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 0c30374.
Which issue does this PR close?
datafusion_expr::window_state::WindowAggState::update#16308Rationale for this change
There is a regression between 48.0.0-rc1 and 48.0.0-rc2 that causes some windowed aggregate tests to fail in Comet.
This PR is a test to see if reverting a recent PR solves the issue. We will run Comet tests in CI pointing to this branch to confirm.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?